Display dependencies in editor #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaedroho
force-pushed
the
dependencies
branch
7 times, most recently
from
6327aa7
to
9b29e96
Compare
kaedroho
force-pushed
the
dependencies
branch
from
9b29e96
to
e8a75db
Compare
kaedroho
force-pushed
the
dependencies
branch
3 times, most recently
from
bd19158
to
3aded28
Compare
KalobTaulien
approved these changes
Nov 9, 2020
| return { | ||
| 'title': str(instance), | ||
| 'isLive': True, | ||
| 'editUrl': reverse('wagtailsnippets:edit', args=[instance._meta.app_label, instance._meta.model_name, quote(instance.id)]), |
There was a problem hiding this comment.
What if the model isnt registered as a snippet? Like if someone goes through the Django Admin, or through the Wagtail ModelAdmin?
There was a problem hiding this comment.
We don't support django/modeladmin right now because it's really hard to tell if a model has been registered with either of those interfaces and what the user permissions are.
I think we should add a sort of "Model registry" into Wagtail, which we can query for this information (might be useful for API and generic choosers too).
kaedroho
force-pushed
the
dependencies
branch
from
3aded28
to
53fb2dd
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.