Synchronise content between locales using alias pages #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaedroho
force-pushed
the
alias-pages-integration
branch
from
2e55ce7
to
d2e688d
Compare
kaedroho
force-pushed
the
alias-pages-integration
branch
2 times, most recently
from
81bf8fc
to
94bb5e4
Compare
kaedroho
force-pushed
the
alias-pages-integration
branch
from
c8b19fd
to
1e06fa5
Compare
kaedroho
changed the title
kaedroho
force-pushed
the
alias-pages-integration
branch
from
1e06fa5
to
d06db66
Compare
KalobTaulien
approved these changes
Nov 9, 2020
| @@ -500,6 +502,10 @@ def create_or_update_translation(self, locale, user=None, publish=True, copy_par | |||
| ingest_segments(original, translation, self.locale, locale, segments) | |||
|
|
|||
| if isinstance(translation, Page): | |||
| # Convert the page into a regular page | |||
| # TODO: Audit logging, etc | |||
There was a problem hiding this comment.
Audit logging. Non blocking imo but probably important to have at some point.
There was a problem hiding this comment.
Thanks! taken note and will implement soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR:
LocaleSynchronisation, this allows users to define locales that should be kept in sync with another localesynctree.pywhich adds signal handlers for synchronising pages to different locale trees using alias pages before they are translated