Pass allowed page types into page chooser #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KalobTaulien
approved these changes
Dec 1, 2020
Fixes #267 Some page choosers have limited page types which could be defined either by the foreign key being set to a specific page type or a list of allowed page types on the PageChooserPanel/Block. This adds support for finding this information from the panel/block and passing it into the widget on the frontend. While implementing this, I discovered an inconsistency with the way we're extracting related page segments from streamfield. On the model, these are extracted as overridable segments, but in streamfield they were being extracted as a translatable related object segments. This PR fixes that as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
Some page choosers have limited page types which could be defined either by the foreign key being set to a specific page type or a list of allowed page types on the PageChooserPanel/Block.
This adds support for finding this information from the panel/block and passing it into the widget on the frontend.
While implementing this, I discovered an inconsistency with the way we're extracting related page segments from streamfield. On the model, these are extracted as overridable segments, but in streamfield they were being extracted as a translatable related object segment. This PR fixes that as well.