Fix test errors against Wagtail main and bump upper version to 2.16 #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 for some reason the actual tests did not run edit: the workflow yaml had an invalid line. note to self: always check the actions tab |
kaedroho
suggested changes
Oct 22, 2021
kaedroho
reviewed
Oct 22, 2021
zerolab
force-pushed
the
chore/fix-nightly-errors-against-main
branch
2 times, most recently
from
f8ec65c
to
23a192e
Compare
kaedroho
approved these changes
Oct 22, 2021
kaedroho
suggested changes
Oct 22, 2021
zerolab
force-pushed
the
chore/fix-nightly-errors-against-main
branch
3 times, most recently
from
25ba297
to
57c525a
Compare
kaedroho
approved these changes
Oct 22, 2021
zerolab
force-pushed
the
chore/fix-nightly-errors-against-main
branch
from
57c525a
to
6d741ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometime after 2.14, the action buttons got a title attribute, hence the test failures.
Added wagtail main as another test option, allowed to fail. And bumped the upper wagtail version to 2.16