Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly errors #536

Merged
merged 4 commits into from Mar 10, 2022
Merged

Fix nightly errors #536

merged 4 commits into from Mar 10, 2022

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Mar 8, 2022

@codecov-commenter
Copy link

Codecov Report

Merging #536 (a78d786) into main (39c32b9) will decrease coverage by 0.29%.
The diff coverage is 38.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   91.63%   91.33%   -0.30%     
==========================================
  Files          37       37              
  Lines        3214     3230      +16     
  Branches      515      522       +7     
==========================================
+ Hits         2945     2950       +5     
- Misses        152      159       +7     
- Partials      117      121       +4     
Impacted Files Coverage Δ
wagtail_localize/views/edit_translation.py 87.12% <28.57%> (-0.90%) ⬇️
wagtail_localize/views/convert.py 71.01% <42.85%> (-3.59%) ⬇️
wagtail_localize/models.py 95.57% <50.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39c32b9...a78d786. Read the comment docs.

Copy link
Contributor

@kaedroho kaedroho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change to improve readability.This otherwise looks good to me, thanks!

wagtail_localize/views/edit_translation.py Outdated Show resolved Hide resolved
@zerolab zerolab merged commit 5964c45 into main Mar 10, 2022
@zerolab zerolab deleted the chore/fix-wagtail217-errors branch March 10, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants