Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default for LOOKUP_FIELDS to include tags #62

Merged
merged 1 commit into from Dec 2, 2020
Merged

Update default for LOOKUP_FIELDS to include tags #62

merged 1 commit into from Dec 2, 2020

Conversation

stevejalim
Copy link

In order to get tags to transfer, WAGTAILTRANSFER_LOOKUP_FIELDS needs 'taggit.tag': ['slug'] adding to it. @jacobtoppm suggested we make this a default, because it's necessary to get taggit tags to work, which are core to Wagtail anyway.

Micro-PR, which I'm told has test coverage already

In order to get tags to transfer, WAGTAILTRANSFER_LOOKUP_FIELDS needs `'taggit.tag': ['slug']` adding to it. @jacobtoppm suggested we make this a default, because it's necessary to get taggit tags to work, which are core to Wagtail anyway.
Copy link
Member

@jacobtoppm jacobtoppm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobtoppm jacobtoppm merged commit 3a6c3e2 into wagtail:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants