Add https support for scribd oembed provider (#739)

Currently scribd defaults to https for their sharing links - http still works but if you copy&paste quickly you may think it's broken
wagtail · Jul 25, 2019 · 1a2bf52 · 1a2bf52
1 parent 1468cab
commit 1a2bf52
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
@@ -7,6 +7,7 @@ Changelog
  * Added `construct_page_listing_buttons` hook (Michael van Tellingen)
  * Added more detailed documentation and troubleshooting for installing OpenCV for feature detection (Daniele Procida)
  * Fix: Added line breaks to long filenames on multiple image / document uploader (Kevin Howbrook)
+ * Fix: Added https support for Scribd oEmbed provider (Rodrigo)
 
 
 2.6 (xx.xx.xxxx) - IN DEVELOPMENT

diff --git a/CONTRIBUTORS.rst b/CONTRIBUTORS.rst
@@ -383,6 +383,7 @@ Contributors
 * jonny5532
 * William Blackie
 * Andrew Miller
+* Rodrigo
 
 Translators
 ===========

diff --git a/docs/releases/2.7.rst b/docs/releases/2.7.rst
@@ -25,6 +25,7 @@ Bug fixes
 ~~~~~~~~~
 
  * Added line breaks to long filenames on multiple image / document uploader (Kevin Howbrook)
+ * Added https support for Scribd oEmbed provider (Rodrigo)
 
 
 Upgrade considerations

diff --git a/wagtail/embeds/oembed_providers.py b/wagtail/embeds/oembed_providers.py
@@ -92,7 +92,7 @@
 scribd = {
     "endpoint": "http://www.scribd.com/services/oembed",
     "urls": [
-        r'^http://[-\w]+\.scribd\.com/.+$',
+        r'^http(?:s)?://[-\w]+\.scribd\.com/.+$',
     ],
 }