Skip to content

Commit

Permalink
added border to tooltip dropdown for high contrast & fix arrow
Browse files Browse the repository at this point in the history
- fixes #8830
  • Loading branch information
anujaraj authored and lb- committed Aug 6, 2022
1 parent c731369 commit 3576e27
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.txt
Expand Up @@ -151,6 +151,7 @@ Changelog
* Fix: Prevent comment buttons from overlapping with fields (Thibaud Colas)
* Fix: Resolve MySQL search compatibility issue with Django 4.1 (Andy Chosak)
* Fix: Ensure that the fields on login and password reset forms are visible in forced colors mode (Paarth Agarwal)
* Fix: Missing a outline on dropdown content and malformed tooltip arrow in forced colors mode (Anuja Verma, LB (Ben) Johnston)


3.0.1 (16.06.2022)
Expand Down
4 changes: 4 additions & 0 deletions client/scss/components/_dropdown.scss
Expand Up @@ -74,6 +74,10 @@
// Override any right alignment that might've been set by a parent element
// (such as the snippets header)
text-align: start;

@media (forced-colors: active) {
border: 2px solid transparent;
}
}

.c-dropdown__item {
Expand Down
15 changes: 9 additions & 6 deletions client/scss/overrides/_utilities.dropdowns.scss
Expand Up @@ -3,9 +3,12 @@
// =============================================================================
.u-arrow:before {
content: '';
border: solid 0.35rem transparent;
background: transparent;
display: block;
position: absolute;
clip-path: polygon(50% 0, 0 100%, 100% 100%);
height: 0.5rem;
width: 0.75rem;
}

.u-arrow--tl:before {
Expand All @@ -21,10 +24,6 @@
// =============================================================================
// Default dropdown theme
// =============================================================================

// .t-default {

// }
.t-default .u-btn-current {
border-color: $color-grey-4;
color: $color-teal;
Expand Down Expand Up @@ -63,7 +62,11 @@
}

.t-dark .u-arrow:before {
border-bottom-color: $color-grey-1;
background-color: $color-grey-1;

@media (forced-colors: active) {
background-color: ButtonText;
}
}

// =============================================================================
Expand Down
1 change: 1 addition & 0 deletions docs/releases/4.0.md
Expand Up @@ -68,6 +68,7 @@ In Wagtail 2.16, we introduced support for Windows High Contrast mode (WHCM). Th
* Add a border around modal dialogs so they can be identified in forced colors mode
* Ensure disabled buttons are distinguishable from active buttons in forced colors mode
* Ensure that the fields on login and password reset forms are visible in forced colors mode
* Missing a outline on dropdown content and malformed tooltip arrow in forced colors mode

### UX unification and consistency improvements

Expand Down

0 comments on commit 3576e27

Please sign in to comment.