-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update keyboard shortcuts menu button & dialog icon to a new 'keyboard' icon #11767
Labels
Milestone
Comments
13 tasks
lb-
changed the title
Update keyboard shortcuts menut button & dialog icon to a new 'keyboard' icon
Update keyboard shortcuts menu button & dialog icon to a new 'keyboard' icon
Mar 16, 2024
Hi @lb-, can I try working on this? It's not my first time, but I haven't worked on this part of the code before. |
Go for it @rohitsrma |
lb-
pushed a commit
to rohitsrma/wagtail
that referenced
this issue
Mar 17, 2024
lb-
pushed a commit
to rohitsrma/wagtail
that referenced
this issue
Mar 17, 2024
lb-
pushed a commit
that referenced
this issue
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your proposal related to a problem?
#11717 introduced a new keyboard shortcuts dialog as part of the work for #3949
For simplicity, we used an existing 'regex' icon for this, it would be nice to support a better icon.
Describe the solution you'd like
keyboard
icon to the core Wagtail admin icon set. (see instructions in the additional context).wagtail/admin/wagtail_hooks.py
seeregister_keyboard_shortcuts_menu_item
for code.wagtail/admin/templates/wagtailadmin/shared/keyboard_shortcuts_dialog.html
.Describe alternatives you've considered
Additional context
Here's the icon SVG (below), we must include the source reference, add this to the folder
wagtail/admin/templates/wagtailadmin/icons
.Also ensure the icon is part of
wagtail/admin/wagtail_hooks.py
seeregister_icons
, adding in alphabetical order.For full instructions on adding icons see https://docs.wagtail.org/en/stable/contributing/ui_guidelines.html#adding-icons Please follow these instructions exactly.
There is no need for an RTL variation of this icon.
Working on this
The text was updated successfully, but these errors were encountered: