Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Much of the example code in the docs uses 2-space indentation, which is not PEP8. #2530

Closed
coredumperror opened this issue Apr 27, 2016 · 3 comments

Comments

@coredumperror
Copy link
Contributor

This has bitten me several times when copy-pasting code from the docs into my projects, as we use 4-space indentation (as PEP8 requires).

Should this be fixed? I'd be happy to do the grunt work, but it'd require perhaps hundreds of changes to the documentation code. I wasn't sure it'd be a good idea to start such a large PR without first getting the go-ahead.

@gasman
Copy link
Collaborator

gasman commented Apr 27, 2016

Have just had a quick scan through the docs, and could only see a small fraction that doesn't use 4-space indentation (most of it template / CSS code rather than Python). Definitely happy for those to be fixed, so a PR would be very welcome!

@coredumperror
Copy link
Contributor Author

I guess I've happened run into an unusual concentration of 2-space Python code (I think a lot of the hook example code may be 2-space), which made me think more of the example code was problematic than it really is.

I'll get to work on that.

@gasman
Copy link
Collaborator

gasman commented Apr 28, 2016

Fixed in #2532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants