Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The page with form submissions is ugly on screens with >=1280px #3759

Closed
m1kola opened this issue Aug 12, 2017 · 3 comments
Closed

The page with form submissions is ugly on screens with >=1280px #3759

m1kola opened this issue Aug 12, 2017 · 3 comments

Comments

@m1kola
Copy link
Contributor

m1kola commented Aug 12, 2017

Issue Summary

The page with form submissions looks ugly on screens with >=1280px.

Steps to Reproduce

  1. Create a form page with title ~35 characters
  2. Submit some data on front-end
  3. Go to the Admin UI -> Forms -> Your form page title

Result

  1. Too much empty space in header when a form page has a long title
  2. Too much place for checkboxes in the submissions table

Expected result

  1. I have no idea how to fix the header
  2. I guess, it should be possible to make the column with checkboxes to have a fixed width

Screenshots

Viewport width 1280px-1215px (desktops):

screen shot 2017-08-12 at 12 25 12

Viewport width ~768px (iPad and other tablets):

screen shot 2017-08-12 at 12 33 26

Technical details

  • Wagtail version: 1.12 (from the master branch, commit e2b5dc3).
  • Browser version: Google Chrome 60.0.3112.90, MacOS 10.12.5 (16F73)
@lb-
Copy link
Member

lb- commented Jul 4, 2022

Proposed solution - we pull out the date search parts from the header completely.

wagtail/contrib/forms/templates/wagtailforms/index_submissions.html

All the search content would go under the <div class="nice-padding"> instead of in the header.

<div class="nice-padding">
        <form action="" method="get" novalidate>
            <div class="col search-bar">
                <ul class="fields row rowflush">
                    {% for field in select_date_form %}
                        {% include "wagtailadmin/shared/field_as_li.html" with field=field field_classes="field-small" li_classes="col4" %}
                    {% endfor %}
                    <li class="submit col2">
                        <button type="submit" name="action" value="filter" class="button button-filter">{% trans 'Filter' %}</button>
                    </li>
                </ul>
            </div>
        </form>

Note: we would need to ensure the form row is not centre aligned but other than that - it looks much better I think.

Screen Shot 2022-07-04 at 4 52 33 pm

Screen Shot 2022-07-04 at 4 52 58 pm

@lb-
Copy link
Member

lb- commented Jul 4, 2022

We will aim to get this resolved as part of the UX unification work in the header - #8539

But in the mean time - marking as a good first issue for anyone to pick up.

Actions required

  • Pull out the form from the header and put into the main content <div class="nice-padding">
  • Remove any scss that no longer applies
  • With styling, fix the date from / date to text wrapping
  • With styling (or maybe utility classes), fix the centre alignment of the dates and ensure they are aligned to the left (start)
  • Might need to update the col classes to be better suited to this row being stand alone
  • Validate in multiple browsers
  • Update unit tests
  • Check the new location works
  • Bonus: Get rid of the inline script tag and put the JS into its own file.

lb- pushed a commit to PaarthAgarwal/wagtail that referenced this issue Jul 19, 2022
- relates to wagtail#8539
- fixes wagtail#3759
- rename index_submissions to submissions_index (aligns with naming of all other index views)
@lb-
Copy link
Member

lb- commented Jul 19, 2022

Will be fixed by #8862 - new layout that streamlines the way the filtering shows.

Screen Shot 2022-07-19 at 8 39 37 pm

lb- pushed a commit to PaarthAgarwal/wagtail that referenced this issue Jul 19, 2022
- relates to wagtail#8539
- fixes wagtail#3759
- fixes wagtail#3236
- rename index_submissions to submissions_index (aligns with naming of all other index views)
@lb- lb- closed this as completed in 0ed07c6 Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants