Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The document chooser: Sorry, no documents match "" #3838

Closed
m1kola opened this issue Sep 7, 2017 · 4 comments
Closed

The document chooser: Sorry, no documents match "" #3838

m1kola opened this issue Sep 7, 2017 · 4 comments
Labels
component:Frontend good first issue Hacktoberfest size:Small sprint:Minsk2018 type:Bug

Comments

@m1kola
Copy link
Contributor

m1kola commented Sep 7, 2017

Issue Summary

The document chooser shows the following message by default when the side doesn't have any documents:

Sorry, no documents match ""

screen shot 2017-09-07 at 12 01 03

Steps to reproduce

  1. Define a document chooser panel in a streamfield or as a separate field
  2. Remove all documents from the document library, if it has any
  3. Click the "Choose a document" button in the editor interface.

Technical details

  • Python version: 3.6.1
  • Django version: 1.11.5
  • Wagtail version: 1.12.1
@m1kola m1kola added this to the some-day milestone Sep 7, 2017
@gmmoraes gmmoraes mentioned this issue Sep 9, 2017
Closed
@thibaudcolas
Copy link
Member

Any takers to quickly define what this UI should show when there are no documents, so that contributors can more easily pick this up and go? Ping @wagtail/ux-design.

@lb-
Copy link
Member

lb- commented Nov 23, 2017

@wagtail/ux-design ideally it should default to the Upload tab being selected first if there are no documents present.

The Search tab could say something like:

No documents uploaded, upload one now.
With the text upload one now being a link to the internal modal tab of Upload.

helmantel pushed a commit to helmantel/wagtail that referenced this issue Mar 14, 2018
Fixed issue wagtail#3838: proper messages in document chooser
a44f813
@jjanssen jjanssen mentioned this issue Mar 14, 2018
Closed
@staaas
Copy link
Contributor

staaas commented Oct 27, 2018

I'm going to work on this during the sprint in Minsk

@staaas staaas mentioned this issue Oct 27, 2018
Closed
@m1kola
Copy link
Contributor Author

m1kola commented Oct 28, 2018

Fixed in #4859

@m1kola m1kola closed this as completed Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:Frontend good first issue Hacktoberfest size:Small sprint:Minsk2018 type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tomdyson @staaas @m1kola @thibaudcolas @lb-