Visual regressions in 3.0rc3

[gasman]

There seems to be several visual regressions in this release compared to rc2

wagtail 3.0rc2

wagtail 3.0rc3

1. Line height issue in the side bar; you can see that the bottom of the g in Pages, Images and Settings is not visible
2. Header background color and border are missing
3. Button no longer in alignment at the width tested (960px)

The header style issues appear on:

• /admin/images/
• /admin/documents/
• /admin/reports/locked/
• /admin/reports/workflow/
• /admin/reports/workflow_tasks/
• /admin/reports/site-history/
• /admin/reports/aging-pages/
• /admin/workflows/list/
• /admin/workflows/tasks/index/
• /admin/users/
• /admin/groups/
• /admin/sites/
• /admin/collections/
• /admin/redirects/

Header appears as expected on /admin/pages/*

modeladmin/inspect.html

I have been working on updating https://github.com/neon-jungle/wagtail-birdsong to be compatible with wagtail 3.0 and have noticed there is also a header issue on views that extend "modeladmin/inspect.html" with rc3

extending "modeladmin/inspect.html" on wagtail 3.0rc2

extending "modeladmin/inspect.html" on wagtail 3.0rc3

Originally posted by @danhayden in #8362 (reply in thread)

[thibaudcolas]

Update:

Line height issue in the side bar

Fixed in 74ed301

Header background color and border are missing

This is intentional

Button no longer in alignment at the width tested (960px)

From my testing this is an issue from widths of 800px to 952px. In the past this was only an issue from 800px to 864. I don’t think the 864px to 952px warrants fixing this at the moment as we’re intending to revisit headers in the future anyway, unless it’s a quick fix.

Breadcrumbs spacing issue

Still TODO!

[thibaudcolas]

Fixed in #8491. I’ve only applied a small part of this to Wagtail 3.0 that only fixes what was reported here – further mobile-specific issues with breadcrumbs will be fixed in 4.0 only.

I’ve created #8539 to further revisit this in the next release as Wagtail shouldn’t have that many header variations to start with, and our implementation badly needs a full refactoring rather than just the reskin we’ve done so far.