-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk actions makes false assumption that ids will always be a number #8563
Comments
lb-
added
type:Bug
component:Frontend
component:Bulk Actions
status:Unconfirmed
Issue, usually a bug, that has not yet been validated as a confirmed problem.
labels
May 19, 2022
8 tasks
lb-
removed
the
status:Unconfirmed
Issue, usually a bug, that has not yet been validated as a confirmed problem.
label
May 31, 2022
lb-
added a commit
to lb-/wagtail
that referenced
this issue
Jun 3, 2022
- add bulk actions baseline tests - move to includes/bulk-actions - fix linting issues - fixes wagtail#8563
3 tasks
lb-
added a commit
to lb-/wagtail
that referenced
this issue
Jun 3, 2022
- add bulk actions baseline tests - move to includes/bulk-actions - fix linting issues - fixes wagtail#8563
lb-
added a commit
to lb-/wagtail
that referenced
this issue
Jun 9, 2022
- add bulk actions baseline tests - move to includes/bulk-actions - fix linting issues - fixes wagtail#8563
lb-
added a commit
to lb-/wagtail
that referenced
this issue
Jun 24, 2022
- add bulk actions baseline tests - move to includes/bulk-actions - fix linting issues - fixes wagtail#8563
lb-
added a commit
to lb-/wagtail
that referenced
this issue
Jul 5, 2022
- add bulk actions baseline tests - move to includes/bulk-actions - fix linting issues - fixes wagtail#8563
lb-
added a commit
to lb-/wagtail
that referenced
this issue
Jul 20, 2022
- add bulk actions baseline tests - move to includes/bulk-actions - fix linting issues - fixes wagtail#8563
lb-
added a commit
to lb-/wagtail
that referenced
this issue
Aug 4, 2022
- add bulk actions baseline tests - move to includes/bulk-actions - fix linting issues - fixes wagtail#8563
lb-
added a commit
that referenced
this issue
Aug 4, 2022
- add bulk actions baseline tests - move to includes/bulk-actions - fix linting issues - fixes #8563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Summary
object.id
will be a number.Steps to Reproduce
wagtail start mysite
& then cd into folderpython manage.py startapp users
users/models.py
AUTH_USER_MODEL = 'users.UserProfile'
pip install -r requirements.txt
(update to Wagtail 3.0 in requirements if needed)python manage.py makemigrations
and thenpython manage.py migrate
python manage.py createsuperuser
python manage.py runserver 0:8000
11a. Expected: It should behave the same way as the other bulk actions when all items are manually selected and select the 'header' checkbox and the 'select all' checked in the footer bulk actions bar.
11b. Actual: When manually selecting all it does not correctly auto-tick the all selected checkbox.
12b. Actual: the bottom bar hide as if nothing was selected.
Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?
Technical details
Root cause
Number(e.target.dataset.objectId)
will convert a non-number toNaN
Screenshots
Screenshot - manually select each item, not showing as 'all selected'
Screenshot - click select all and manually unselect one item - showing in broken state
Screenshot - user object id as uuid (not a normal number)
The text was updated successfully, but these errors were encountered: