-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt core shared header for ModelAdmin headers #8907
Comments
17 tasks
Closed
3 tasks
3 tasks
Thanks. I'll flag it for review. |
lb-
pushed a commit
to salty-ivy/wagtail
that referenced
this issue
Feb 23, 2023
Will need to raise a new issue after this - the clean up step above and probably should try to align the right/left class names with BEM naming if possible. |
lb-
pushed a commit
to salty-ivy/wagtail
that referenced
this issue
Feb 23, 2023
lb-
pushed a commit
that referenced
this issue
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your proposal related to a problem?
ModelAdmin
header is one of the last major header usage within the admin that is not using the using the core (non-slim) shared header template.Describe the solution you'd like
Describe alternatives you've considered
Additional context
Notes for potential implementation approach
wagtail/contrib/modeladmin/templates/modeladmin/includes/header.html
that extendswagtail/admin/templates/wagtailadmin/shared/header.html
with
added in thewagtail/contrib/modeladmin/templates/modeladmin/index.html
to pass down the right variables.{% block h1 %}
inside<div class="col">
{% if view.header_icon %}
will need to be replace with that icon being passed into the includeview.get_page_title
will need to be passed into the includeself.get_page_subtitle
will need to be passed into the include{% include 'modeladmin/includes/result_count.html' %}
will need to be passed into the include asdescription
(with a release note change that this now appears outside theh1
tag (which makes sense){% if search_url %}
will need to be wrapped in a block{% block search %}
{% block header_extra %}
should probably be set up as a fragment and passed intoextra_actions
on the include (this is a small breaking change, this block will no longer render outside.right
column but this should be ok toblock
right_column_classname
and ensure the styles still work, remove any now unused styles, add release note about this no longer being supported.The text was updated successfully, but these errors were encountered: