-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New styles for footer actions #9030
Comments
This should ideally involve fixing #6591. |
Hi @thibaudcolas I was wondering if this is still open for anyone to work on? |
Hi @ForJessicaSake, yep, I don’t think anyone else has worked on this. |
Okay great, I’ll work on it can you please assign it to me @thibaudcolas 😊 thank you! |
@ForJessicaSake we do not assign issues (outside of core team) so feel free to just start on this. |
Okay noted, I’ll do just that |
Hi @ForJessicaSake, can you let us know where you got to with this? Please let us know if you have any questions. |
Hi @ForJessicaSake are you still working on this please? |
Hi @thibaudcolas, is anyone working on this issue? |
@Seremba feel free to give this a go as we have not heard back from @ForJessicaSake for some time. |
Hi, @thibaudcolas @lb- would you mind pointing me to the file for these changes? |
I’ve done quite a bit of the work on this in #11456 – the footer actions code is much simpler now, so should be easier for us to complete this ticket. There were a few snags:
See #11456 for a few screenshots. And more generally:
Another snag was that footer actions markup currently is copy-pasted all over the place, with lots of inconsistencies. So as part of completing this I think we need to refactor the code to have an implementation that’s easier to reuse. Particularly in the context of #9869. |
Assigning back to @benenright for a review of how we can tweak the designs to complete this, based on my notes above. Here are specific problem scenarios that might warrant design changes. Footer actions with warning messageBulk actionsBulk actions with "Select all" linkDemo page: images listing – this link only appears only listings with more items than the listing can show. |
I think that we should keep the background indigo, as I don't think there is much value in trying to make a light background work behind these actions, and the potential usability issues outway the original intention... The original intention was to reduce the visual weight of the form footer actions - being something that sticks on the browser bottom edge, it felt like this was worth trying. But in the context of the bulk actions, that only appear once triggered by selecting a checkbox, the dark background helps users to notice it, and if we move to a lower contrast background, it risks them not being noticed (some usability testing we did a while back showed that some users expected these bulk actions to appear at the top of the listing (as per Gmail for eg), but since the indigo bg was high contrast with the page bg, people did notice it at bottom). I do think it would be worth revisiting how we ensure good contrast for this type of panel specifically in dark mode (as the low contrast means we likely have that usability issue where people don't notice it appear): |
@benenright I forgot one other variation on footer actions, which is used when viewing a past version of a page: This is testable on this past revision demo page. Could you give us design guidance for that as well? re bulk actions, anecdotally we received related feedback from low-vision users (though it’s low on details so I’m following up):
|
Here are the styles of this specific component:
And more generally of all dropdowns like this: https://www.figma.com/file/h67EsVXdWsfu38WGGxWfpi/Wagtail-Design-System?node-id=1241%3A18660
Ideally we’d only get to this after @wagtail/gsoc-ux-unification has implemented their changes to the JS side of this.
Note for footer actions – there is much more than just the dropdown, we also need to make sure the new styles work with the bulk chooser’s components, and with our dirty form check messages.
As part of this, we could also add this component to the user creation screen to help with #5906. Ideally #7366, #6591, #7650 will have also been fixed.
Sub-tasks:
The text was updated successfully, but these errors were encountered: