Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New styles for footer actions #9030

Open
3 tasks done
thibaudcolas opened this issue Aug 18, 2022 · 16 comments
Open
3 tasks done

New styles for footer actions #9030

thibaudcolas opened this issue Aug 18, 2022 · 16 comments

Comments

@thibaudcolas
Copy link
Member

thibaudcolas commented Aug 18, 2022

Here are the styles of this specific component:

Image

And more generally of all dropdowns like this: https://www.figma.com/file/h67EsVXdWsfu38WGGxWfpi/Wagtail-Design-System?node-id=1241%3A18660

Ideally we’d only get to this after @wagtail/gsoc-ux-unification has implemented their changes to the JS side of this.

Note for footer actions – there is much more than just the dropdown, we also need to make sure the new styles work with the bulk chooser’s components, and with our dirty form check messages.

As part of this, we could also add this component to the user creation screen to help with #5906. Ideally #7366, #6591, #7650 will have also been fixed.

Sub-tasks:

@thibaudcolas thibaudcolas added this to the 4.1 milestone Aug 18, 2022
@thibaudcolas thibaudcolas assigned laymonage and unassigned stevedya Oct 7, 2022
@thibaudcolas
Copy link
Member Author

This should ideally involve fixing #6591.

@thibaudcolas thibaudcolas removed this from the 4.1 milestone Oct 7, 2022
@ForJessicaSake
Copy link

Hi @thibaudcolas I was wondering if this is still open for anyone to work on?

@thibaudcolas
Copy link
Member Author

Hi @ForJessicaSake, yep, I don’t think anyone else has worked on this.

@ForJessicaSake
Copy link

ForJessicaSake commented Oct 13, 2022

Okay great, I’ll work on it can you please assign it to me @thibaudcolas 😊 thank you!

@lb-
Copy link
Member

lb- commented Oct 14, 2022

@ForJessicaSake we do not assign issues (outside of core team) so feel free to just start on this.

@ForJessicaSake
Copy link

Okay noted, I’ll do just that

@thibaudcolas
Copy link
Member Author

Hi @ForJessicaSake, can you let us know where you got to with this? Please let us know if you have any questions.

@Seremba
Copy link
Contributor

Seremba commented Oct 27, 2022

Hi @ForJessicaSake are you still working on this please?

@Seremba
Copy link
Contributor

Seremba commented Nov 8, 2022

Hi @thibaudcolas, is anyone working on this issue?

@lb-
Copy link
Member

lb- commented Nov 8, 2022

@Seremba feel free to give this a go as we have not heard back from @ForJessicaSake for some time.

@Seremba
Copy link
Contributor

Seremba commented Nov 9, 2022

Hi, @thibaudcolas @lb- would you mind pointing me to the file for these changes?

@lb-
Copy link
Member

lb- commented Nov 16, 2022

@Seremba have a look at this PR - it touches the same area of the UI.

#9643

However, it's good to learn how to find these things yourself. The best way is to look at the CSS classes in the DOM and search through the code in your editor.

@thibaudcolas thibaudcolas changed the title Restyle footer actions according to new designs Re-implement footer actions according to new designs Nov 17, 2022
@thibaudcolas thibaudcolas self-assigned this Mar 21, 2023
@thibaudcolas
Copy link
Member Author

thibaudcolas commented Jan 18, 2024

I’ve done quite a bit of the work on this in #11456 – the footer actions code is much simpler now, so should be easier for us to complete this ticket. There were a few snags:

  • The proposed widths for the sticky actions would mean a lot more wrapping of text to two lines for languages longer than english (so I stopped at 310px rather than the 250px in the designs)
  • The designs in Ben’s original screenshot here have too low contrast between the footer actions background and the page background in my opinion. Not sure this is an actual issue but I found it hard on the eye to not know exactly what part of the page was sticky and what was within. Something I’d like to discuss at least.
  • The footer actions also need adapting for the page / snippet revisions’ "review" mode.

See #11456 for a few screenshots.

And more generally:

  • Those styles need to work for both footer actions on "forms", and bulk actions. Currently we only have designs for very simple "form" footer actions, while the bulk actions are more complex visually
  • We need to make sure the footer actions also support having text within, the "unsaved page data" warning and also meta text for bulk actions.

Another snag was that footer actions markup currently is copy-pasted all over the place, with lots of inconsistencies. So as part of completing this I think we need to refactor the code to have an implementation that’s easier to reuse. Particularly in the context of #9869.

@thibaudcolas thibaudcolas changed the title Re-implement footer actions according to new designs New styles for footer actions Jan 22, 2024
@thibaudcolas
Copy link
Member Author

thibaudcolas commented Sep 2, 2024

Assigning back to @benenright for a review of how we can tweak the designs to complete this, based on my notes above. Here are specific problem scenarios that might warrant design changes.

Footer actions with warning message

footer actions with warning text

Bulk actions

bulk actions

Bulk actions with "Select all" link

Demo page: images listing – this link only appears only listings with more items than the listing can show.

bulk actions select all

@benenright
Copy link

I think that we should keep the background indigo, as I don't think there is much value in trying to make a light background work behind these actions, and the potential usability issues outway the original intention...

The original intention was to reduce the visual weight of the form footer actions - being something that sticks on the browser bottom edge, it felt like this was worth trying. But in the context of the bulk actions, that only appear once triggered by selecting a checkbox, the dark background helps users to notice it, and if we move to a lower contrast background, it risks them not being noticed (some usability testing we did a while back showed that some users expected these bulk actions to appear at the top of the listing (as per Gmail for eg), but since the indigo bg was high contrast with the page bg, people did notice it at bottom).

I do think it would be worth revisiting how we ensure good contrast for this type of panel specifically in dark mode (as the low contrast means we likely have that usability issue where people don't notice it appear):

image

@thibaudcolas
Copy link
Member Author

@benenright I forgot one other variation on footer actions, which is used when viewing a past version of a page:

footer actions past revision

This is testable on this past revision demo page. Could you give us design guidance for that as well?


re bulk actions, anecdotally we received related feedback from low-vision users (though it’s low on details so I’m following up):

Given the page layout it wasn’t immediately apparent that it was possible to affect the pages from the list view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Ready
Status: Design
Development

No branches or pull requests

7 participants