Limit displayed models in audit logging based on permissions

[th3hamm0r]

Is your proposal related to a problem?

Currently, a user which for example is only allowed to edit pages (like users of the default editor group), still sees every logged change of any model in the audit log, e.g. changed site settings or changed users (if a superuser has changed them for example), which he actually can't see/edit, therefore he often would not know of their existence, which is bad...
The user cannot view the underlying objects, because if the view permission is missing, there is no link, so that's good! But I think he should not see any log entries of models, for which he doesn't have at least the view permission.

Describe the solution you'd like

Basically, the querysets used for the filters and the listings should only use the content types, which at least can be viewed by the user.

On a first quick look I think it probably requires changes to the filter here (probably by adding/changing the API to contain a user to be used to filter get_content_type_ids()):

wagtail/wagtail/admin/views/reports/audit_logging.py

Lines 34 to 37 in 519caf2

	def get_content_types_for_filter():
	content_type_ids = set()
	for log_model in log_action_registry.get_log_entry_models():
	content_type_ids.update(log_model.objects.all().get_content_type_ids())

and changes to the listing's queryset (probably by changing viewable_by_user()):

wagtail/wagtail/admin/views/reports/audit_logging.py

Lines 147 to 156 in 519caf2

	self.log_models = list(log_action_registry.get_log_entry_models())
	for log_model_index, log_model in enumerate(self.log_models):
	sub_queryset = (
	log_model.objects.viewable_by_user(self.request.user)
	.values("pk", "timestamp")
	.annotate(
	log_model_index=Value(log_model_index, output_field=IntegerField())
	)
	)

If you are ok with my proposal, I could, maybe with some guidance, try to implement a PR for that.

[gasman]

reopening as #11020 is only a partial fix