Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styles for userbar and a11y checker in dark mode #10648

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

albinazs
Copy link
Contributor

@albinazs albinazs commented Jul 7, 2023

As part of #10418

Update styles for userbar and a11y checker in dark mode:

  • Dark theme applied for the userbar (except for the trigger button) and a11y checker (pass missing context information for the dialog element via fragment)
  • Few tweaks for a11y checker's as-is dark mode implementation (close icon, selector button)

Light theme is not affected

Before After
image image
image image

Please check the following:

  • Do the tests still pass?1
  • Does the code comply with the style guide?
    • Run make lint from the Wagtail root.
  • For Python changes: Have you added tests to cover the new/fixed behaviour?
  • For front-end changes: Did you test on all of Wagtail’s supported environments?2
    • Please list the exact browser and operating system versions you tested:
      Chrome 113, Firefox 113, Safari 16.3 macOS 13.2
    • Please list which assistive technologies 3 you tested:
      Color contrast check
  • For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.

Footnotes

  1. Development Testing

  2. Browser and device support

  3. Accessibility Target

@squash-labs
Copy link

squash-labs bot commented Jul 7, 2023

Manage this branch in Squash

Test this branch here: https://albinazsfeature10418-userbar-d-efodt.squash.io

@thibaudcolas thibaudcolas self-requested a review July 7, 2023 13:40
@laymonage laymonage added this to the 5.1 milestone Jul 11, 2023
Copy link
Member

@lb- lb- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@lb- lb- force-pushed the feature/10418-userbar-design branch from 71ba6ba to f35e9d7 Compare July 16, 2023 11:42
@lb- lb- merged commit 457e260 into wagtail:main Jul 16, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants