PublishMenuItem label is not overridable through hook #10664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://sebcorbinissue-10663-7goy0.squash.io |
|
@SebCorbin are you able to look at the CI failures? |
lb-
added
status:Needs Review
component:Menu
lb-
approved these changes
Sep 17, 2023
There was a problem hiding this comment.
This works great, I know there was a bigger discussion in #10663 about solving some of the larger complexities with hooks and menu items. For now though, let's get this small win into the code, it works well and makes sense.
If you feel there should be more fixes to the menu hooks, please let's discuss them as new issues or Discussion items.
Validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10663
Please check the following:
make lintfrom the Wagtail root.