Use a theme-agnostic color token for read-only panels support in dark mode #10689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://thibaudcolasbug10418-readonly-7kfco.squash.io |
thibaudcolas
added
type:Bug
component:Design system
laymonage
approved these changes
Jul 18, 2023
laymonage
force-pushed
the
bug/10418-readonly-dark-mode
branch
from
a3c2129
to
f8da5f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the last issue tracked on #10418, with
read_only=TrueFieldPanel.surface-field-inactiveis currently used fordisabledfields.I’ve additionally customised the border for consistency with disabled fields.