Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable breadcrumbs outside of pages, SnippetViewSet, and custom ModelViewSet #10915

Merged

Conversation

laymonage
Copy link
Member

@laymonage laymonage commented Sep 18, 2023

Undo the breadcrumbs unintentionally added in #10880 and intentionally added in #10884 until we can implement the designs that are better suited for various use cases throughout the admin.

To re-enable in the future, revert the first two commits from this PR.

I also added a commit to disable the minimap if there are no panel anchors found, to prevent the minimap from rendering on the ModelViewSet views as they currently don't use panels. When they do support panels after #10830, the minimap should be rendered automatically.

Please check the following:

  • Do the tests still pass?1
  • Does the code comply with the style guide?
    • Run make lint from the Wagtail root.
  • For Python changes: Have you added tests to cover the new/fixed behaviour?

Please describe additional details for testing this change.

Use my bakerydemo branch: https://github.com/laymonage/bakerydemo/tree/country-modelviewset

And see that:

  • The views for County of Origin still have breadcrumbs (and status side panel)
  • The views for all snippets still have breadcrumbs
  • The following views do not have breadcrumbs at all:
    • Workflows
    • Workflow tasks
    • Users
    • Groups
    • Sites
    • Locales
    • Collections

Footnotes

  1. Development Testing

@squash-labs
Copy link

squash-labs bot commented Sep 18, 2023

Manage this branch in Squash

Test this branch here: https://laymonagedisable-unintentional-b5t6i.squash.io

@laymonage laymonage changed the title Disable unintentional breadcrumbs Disable breadcrumbs outside of pages, SnippetViewSet, and custom ModelViewSet Sep 19, 2023
@laymonage laymonage self-assigned this Sep 19, 2023
@laymonage laymonage added component:Design system Including the pattern library (Storybook) component:Viewsets labels Sep 19, 2023
@laymonage laymonage added this to the 5.2 milestone Sep 19, 2023
@laymonage laymonage force-pushed the disable-unintentional-breadcrumbs branch from 09936f2 to a89fef5 Compare October 5, 2023 15:29
@laymonage laymonage marked this pull request as ready for review October 5, 2023 15:59
@laymonage laymonage force-pushed the disable-unintentional-breadcrumbs branch from 331a9a8 to f109e7b Compare October 5, 2023 16:02
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @laymonage! Looking good in Safari & Chrome.

@thibaudcolas thibaudcolas merged commit 78a349b into wagtail:main Oct 19, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants