Broken checkboxes in MultipleChooserPanel modal when USE_THOUSAND_SEPARATOR is True

[codesmith25103]

Fixes #...
Issue Number #11134
I attempt to solve the issue as it was mentioned in PR. I have used the filter "|unlocalize" at a correct place to solve this issue

Please check the following:

• Do the tests still pass?¹
• Does the code comply with the style guide?
  • Run make lint from the Wagtail root.
• For Python changes: Have you added tests to cover the new/fixed behaviour?
• For front-end changes: Did you test on all of Wagtail’s supported environments?²
  • Please list the exact browser and operating system versions you tested:
  • Please list which assistive technologies ³ you tested:
• For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.

Footnotes

1. Development Testing ↩

2. Browser and device support ↩

3. Accessibility Target ↩

[squash-labs]

Manage this branch in Squash

Test this branch here: https://codesmith25103main-agok7.squash.io

[gasman]

The other occurrence of value (in "chooser-modal-select-{{ value }}") needs updating too. Have also just noticed that there's another template that needs the same fixes - wagtail/admin/templates/wagtailadmin/chooser/tables/page_checkbox_select_cell.html

[codesmith25103]

Thanks for reviewing. I will make required changes.

[codesmith25103]

I have made required changes. Please review it

[lb-]

It might be good to have a unit test supporting this also, so that it doesn't break again in the future.

[gasman]

This is currently failing when I test it on the bakerydemo site (by editing any blog page, and clicking the "Add author" button which should open the chooser popup) because the template isn't loading the l10n tag library (which is required for the unlocalize filter).

I would have expected the existing unit tests to catch this error, so it seems that we're lacking some test coverage for this.

[codesmith25103]

So do I have to write unit test to catch this error?

[codesmith25103]

I have added l10n tag in both the files. Hope it will resolve the issue.

[lb-]

@codesmith25103 you may want to add a test for this change.

• wagtail/admin/tests/test_edit_handlers.py - see TestMultipleChooserPanel - this is more for the panel itself, probably not the view that responds with the checkboxes.
• For the multiple chooser response view, I cannot see that we have a test for this view specifically. It probably needs to go here wagtail/admin/tests/test_page_chooser.py. In the class TestChooserBrowse a new test that requests with multiple=1 should get you started.

The view is located in wagtail/admin/views/chooser.py (see BrowseView) and the URL is set up in wagtail/admin/urls/__init__.py.

class TestChooserBrowse(WagtailTestUtils, TestCase):

    @override_settings(USE_THOUSAND_SEPARATOR=True)
    def test_multiple_chooser_view(self):
        response = self.get({"multiple": "1"})  # something like this
        self.assertEqual(response.status_code, 200)
        self.assertTemplateUsed(response, "wagtailadmin/chooser/browse.html")
        # check that the values are correct
        # We may need to add a page that has an id of over 1000
        # we will also need to test this with the setting turned off
        # test data is set in wagtail/test/testapp/fixtures/test.json but we can also add a page on the fly in this test

Hopefully that helps as a starting point, a similar test will be needed for the generic multiple chooser but maybe get the page one working first.

[lb-]

@codesmith25103 are you OK to create a unit test for this?

[codesmith25103]

Hey @lb-, I apologize for the delay. Due to some health and family issues, I wasn't able to complete it. However, I have already started working on it and will update you soon.

[lb-]

No problems @codesmith25103 - I hope you and your family are OK.

[lb-]

Thanks @codesmith25103 looks like a new PR has taken this and added unit tests.
#11490

We will ensure we mention you in the release notes, thanks for getting this started.