Refactor float usage within admin styles. Fix #8126 #11360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of our work to support RTL languages – fixes #8126.
Browser support
Now that browser support is good enough for logical
float
values, we can switch to using them. Browser support started being good enough in October 2023 with Chrome 118. The latest Chrome version is currently 120 so we’re already above our "last 2" browser support target for Chrome.According to the Chrome roadmap, by the time Wagtail 6.0 ships in February, Chrome 121 will have been out for two weeks, so we will support the "last 4" versions of Chrome (121, 120, 119, 118).
Testing this
There isn’t much testing to do at all – it’s a very mechanical replacement of values from physical to logical, and the browser does the rest. There are 134 occurrences of
float
across the project, so they can all be checked in the code.Please check the following:
[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?[ ] For new features: Has the documentation been updated accordingly?