Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor float usage within admin styles. Fix #8126 #11360

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

thibaudcolas
Copy link
Member

Part of our work to support RTL languagesfixes #8126.

Browser support

Now that browser support is good enough for logical float values, we can switch to using them. Browser support started being good enough in October 2023 with Chrome 118. The latest Chrome version is currently 120 so we’re already above our "last 2" browser support target for Chrome.

According to the Chrome roadmap, by the time Wagtail 6.0 ships in February, Chrome 121 will have been out for two weeks, so we will support the "last 4" versions of Chrome (121, 120, 119, 118).

Testing this

There isn’t much testing to do at all – it’s a very mechanical replacement of values from physical to logical, and the browser does the rest. There are 134 occurrences of float across the project, so they can all be checked in the code.

Please check the following:

  • Do the tests still pass?[^1]
  • Does the code comply with the style guide?
  • [ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
  • For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]
    • Please list the exact browser and operating system versions you tested: Chrome 120 macOS 14, Safari 17 macOS 14
    • Please list which assistive technologies [^3] you tested: None
  • [ ] For new features: Has the documentation been updated accordingly?

@thibaudcolas thibaudcolas added type:Enhancement component:UI localization l10n & i18n for admin interface only labels Dec 18, 2023
@thibaudcolas thibaudcolas added this to the 6.0 milestone Dec 18, 2023
Copy link

squash-labs bot commented Dec 18, 2023

Manage this branch in Squash

Test this branch here: https://thibaudcolas8126-logical-float-ruqek.squash.io

@laymonage laymonage merged commit 6cc4533 into wagtail:main Dec 19, 2023
18 checks passed
@thibaudcolas thibaudcolas deleted the 8126-logical-float branch December 19, 2023 15:44
thibaudcolas added a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:UI localization l10n & i18n for admin interface only type:Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and replace usage of float layouts in admin UI for RTL support
2 participants