Update hook names. Fixes #870 #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +87,8 @@ Admin | |||
| * Added cache-control headers to all admin views. This allows Varnish/Squid/CDN to run on vanilla settings in front of a Wagtail site | |||
| * Date / time pickers now consistently use times without seconds, to prevent Javascript behaviour glitches when focusing / unfocusing fields | |||
| * Added hook ``construct_homepage_summary_items`` for customising the site summary panel on the admin homepage | |||
| * Renamed the ``construct_wagtail_edit_bird`` hook to ``construct_wagtail_edit_bird`` | |||
|
Ready for another glance. |
|
Looks good to me. @gasman would probably want to look at this before merge |
|
Looks good to me too - I think it warrants an entry in the 'Upgrade considerations' section of the release notes too, though. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #870.
Did not rename
construct_whitelister_element_rulestoconstruct_whitelisted_element_rulesas it refers directly towagtail.wagtailcore.whitelist.Whitelister(a generic HTML whitelisting engine)