Support forwards compatible configuration for private pages/collections #11854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lb-
added
status:Needs Review
Release blocker
component:Privacy
Manage this branch in SquashTest this branch here: https://lb-cleanupupdate-shared-passwo-95w7i.squash.io |
The new settings introduced in wagtail#11582 / wagtail#11536 only considered one use case of disabling the shared password option. However, we may want to allow for more complex configuration in the future in this area. Ensure we can support potential future requirements such as wagtail#11640 with a more flexible structure for private pages & collections. The following settings have been changed from boolean to dictionary values. WAGTAIL_ALLOW_SHARED_PASSWORD_PAGE -> WAGTAIL_PRIVATE_PAGE_OPTIONS WAGTAIL_ALLOW_SHARED_PASSWORD_COLLECTION -> WAGTAILDOCS_PRIVATE_COLLECTION_OPTIONS
lb-
force-pushed
the
cleanup/update-shared-password-settings-with-more-flexibility
branch
from
fea6dd0
to
845dcaf
Compare
|
I have just updated this PR, we should be using It is a bit confusing using the COLLECTION name here but I think it's the right way to communicate that this impacts the privacy for documents via collections. Plus all other documents module items are prefixed with |
gasman
approved these changes
Apr 17, 2024
lb-
deleted the
cleanup/update-shared-password-settings-with-more-flexibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new settings introduced in #11582 / #11536 only considered one use case of disabling the shared password option. However, we may want to allow for more complex configuration in the future in this area.
Ensure we can support potential future requirements such as #11640 with a more flexible structure for private pages & collections.
The following settings have been changed from boolean to dictionary values.
WAGTAIL_ALLOW_SHARED_PASSWORD_PAGE→WAGTAIL_PRIVATE_PAGE_OPTIONSWAGTAIL_ALLOW_SHARED_PASSWORD_COLLECTION→WAGTAILDOCS_PRIVATE_COLLECTION_OPTIONSExample configuration
Reminder: The changed settings are not yet released, no deprecation needed, hopefully this can be merged in for 6.1 so we do not have to change/deprecate things in the future here.