Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render listing buttons as components #11939

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Render listing buttons as components #11939

wants to merge 1 commit into from
+95 −25

Commits on May 9, 2024

  1. Render listing buttons as components 

    Instead of manually rendering them via the parent dropdown component and
a custom template, delegate each button's rendering to itself by making
use of the default Button template added in
2274a44 and the {% component %} tag.

This allows the buttons inside the dropdown to have their own markup,
e.g. to use a <button> element instead of <a>.

Remove the `button button-small button-secondary` CSS classes from the
base ListingButton class. We'll assume instances of this class is
rendered inside a dropdown, and hence do not need the extra CSS. If
people still do need it, advise them to add it to the classname
themselves.
    @laymonage
    laymonage committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a467e71 View commit details
    Browse the repository at this point in the history