Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use model specific "DoesNotExist" exception #1768

Merged
merged 1 commit into from
Oct 3, 2015

Conversation

annp89
Copy link

@annp89 annp89 commented Oct 3, 2015

Replace base class ObjectDoesNotExist exception with model specific ``DoesNotExist` exception

kaedroho added a commit that referenced this pull request Oct 3, 2015
Use model specific "DoesNotExist" exception
@kaedroho kaedroho merged commit 6afc3a9 into wagtail:master Oct 3, 2015
@gasman
Copy link
Collaborator

gasman commented Oct 4, 2015

This will break when custom image models are in use, because they will use their own subclass of AbstractRendition rather than Rendition. Reverted in #1773

@kaedroho
Copy link
Contributor

kaedroho commented Oct 4, 2015

Oops, that slipped my mind. Thanks for reverting.

We really ought to have tests for custom image models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants