Fix #1732 Show asterisk after required StreamField block labels #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,9 +5,9 @@ | |||
|
|
|||
| <ul class="fields"> | |||
| {% for child in children.values %} | |||
| <li> | |||
| <li{% if child.block.field.required %} class="required"{% endif %}> | |||
There was a problem hiding this comment.
We probably want to avoid referring to child.block.field here - block objects don't always wrap a Django form field, and the ones that don't might have a different idea of how "required-ness" is defined. I think we can fix this nicely by adding a standard required property to Block (which would be false by default, and pick up the value from self.field in the case of FieldBlock) - I'll make this change.
|
Merged in e9279c8 + parents - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1732. Not sure the SCSS is in the approved place but it works.
Also added a colon for consistency with normal field labels.