Extract send_mail logic in AbstractEmailForm #2926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this part of the form process
m1kola
added a commit
that referenced
this pull request
Aug 26, 2016
Also contails release notes for #2926
This was referenced Aug 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it has to be possible to override the behaviour of sending out email while processing the emailform, for example to support HTML mail or provide your custom template.
Since
super(AbstractEmailForm, self).process_form_submission(form)is called and this super method is still need, I've moved the send_mail logic to a separate function which can be overridden.While working on it I took the liberty to tackle the issue described in #2833