Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm-run-all due to malicious subdependency #4930

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

jjanssen
Copy link
Member

In the past week somebody notifed a Bitcoin stealer within the flatmap-stream module. As this commonly found with the sub-dependency (of its sub-dependencies) this became a huge deal for the development infrastructure of a lot of people.

Within our current setup flatmap-stream is used by npm-run-all as part of our front-end tooling chain for building. This PR updates npm-run-all and makes sure flatmap-stream is removed from its sub-dependencies.

More reading about this:
dominictarr/event-stream#116
mysticatea/npm-run-all#154

https://www.theregister.co.uk/2018/11/26/npm_repo_bitcoin_stealer/
https://medium.com/@jsoverson/exploiting-developer-infrastructure-is-insanely-easy-9849937e81d4

@jjanssen
Copy link
Member Author

Command for double-checking your local environment:
npm ls event-stream flatmap-stream

wagtail (master)*$ npm ls event-stream flatmap-stream
wagtail@1.0.0 /Users/j.janssen/Sites/git-projects/wagtail-jjanssen
└── (empty)

Which should now return empty.

@mikedingjan mikedingjan self-requested a review November 28, 2018 10:53
@gasman gasman merged commit 80ef955 into wagtail:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants