Update npm-run-all due to malicious subdependency #4930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past week somebody notifed a Bitcoin stealer within the
flatmap-stream
module. As this commonly found with the sub-dependency (of its sub-dependencies) this became a huge deal for the development infrastructure of a lot of people.Within our current setup
flatmap-stream
is used bynpm-run-all
as part of our front-end tooling chain for building. This PR updatesnpm-run-all
and makes sureflatmap-stream
is removed from its sub-dependencies.More reading about this:
dominictarr/event-stream#116
mysticatea/npm-run-all#154
https://www.theregister.co.uk/2018/11/26/npm_repo_bitcoin_stealer/
https://medium.com/@jsoverson/exploiting-developer-infrastructure-is-insanely-easy-9849937e81d4