Move and refactor upgrade notification JS #5256
Conversation
Manage this branch in SquashTest this branch here: https://neon-junglerefactor-js-upgrade-3hi0o.squash.io |
| * "url" : "https://wagtail.io" // Absolute URL to page/file containing release notes or actual package. It's up to you. | ||
| * } | ||
| */ | ||
| const releasesUrl = 'https://releases.wagtail.io/latest.txt'; |
There was a problem hiding this comment.
Just a thought - would there be any benefit in storing the releaseUrl on the container also?
benefits - can be customisable by devs without needing to load different JS (edge case probably), means the function itself contains less data hard coded (eventually the URL could be pulled out further into a tag or constant elsewhere.
There was a problem hiding this comment.
Yeah sure. I think this is a good idea - off the top of my head I can see how this might be useful for CodeRed style projects.
There was a problem hiding this comment.
This is looking good 🙂 @lb- @jonnyscholes is there anything else you’d want to see here or is it good to go as-is?
| }); | ||
| it('compares 2.6a0 and 2.4 correctly', () => { | ||
| expect(versionOutOfDate('2.6a0', '2.4')).toBeTruthy(); | ||
| }); |
|
This is good to go, I have merged it in with some resolved conflicts all sorted. @jonnyscholes - merged in via c0af26b I think there were two outstanding items, not blockers though.
|
Part of #5252. This PR moves the upgrade notification JS to wagtail-client. I've re-written it for the most part, given it's simplicity including, removing its jQuery dependance.
Probably look at #5254 first because it raises some related questions.
Do the tests still pass? (http://docs.wagtail.io/en/latest/contributing/developing.html#testing) Yes.
Does the code comply with the style guide? (Run make lint from the Wagtail root) Yes.
For Python changes: Have you added tests to cover the new/fixed behaviour? N/A
For front-end changes: Did you test on all of Wagtail’s supported browsers?
Chrome 73 MacOS
Safari 12.0 MacOS
Firefox 66.0 MacOS
For new features: Has the documentation been updated accordingly? N/A