Fix elasticsearch search backend tests broken by #5208 #5391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gasman I'm not entirely sure why, but indexing 'id' field instead of 'pk' seems to fix the broken search backend tests (as reported here: #5208 (comment))
I've also updated
IndexView.get_ordering()
to always use the field name when modifying the ordering. If indexing 'pk' isn't supported for some reason, we want to avoid raisingIndexError
messages that encourage the user to index 'pk'.