Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the stream block id initialization #5552

Closed
wants to merge 2 commits into from
Closed

Updated the stream block id initialization #5552

wants to merge 2 commits into from

Commits on Sep 5, 2019

  1. Updated the block id initialization 

    The current block id generation only sets the id as the block is serialized for storage in the database, which means that the id is unavailable in the block until it is pulled back from the database. In my debugging this caused the id to be set to new values up to 3 times when saving a brand new page (each time with a new id).
This updated logic applies the new id to the actual block which makes it available right away and prevents the id from being regenerated.
    @colink-eb
    colink-eb committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    27dd381 View commit details
    Browse the repository at this point in the history

  2. Corrected the id assignment behavior for dictionaries.

    @colink-eb
    colink-eb committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    77593d5 View commit details
    Browse the repository at this point in the history