Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating FieldDoesNotExist imports to all be django.core.exceptions. #5581

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions wagtail/admin/edit_handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
import re

from django import forms
from django.core.exceptions import ImproperlyConfigured
from django.db.models.fields import FieldDoesNotExist
from django.core.exceptions import FieldDoesNotExist, ImproperlyConfigured
from django.forms.formsets import DELETION_FIELD_NAME, ORDERING_FIELD_NAME
from django.forms.models import fields_for_model
from django.template.loader import render_to_string
Expand Down
3 changes: 1 addition & 2 deletions wagtail/contrib/modeladmin/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@
get_fields_from_path, label_for_field, lookup_needs_distinct, prepare_lookup_value, quote, unquote)
from django.contrib.auth.decorators import login_required
from django.core.exceptions import (
ImproperlyConfigured, ObjectDoesNotExist, PermissionDenied, SuspiciousOperation)
FieldDoesNotExist, ImproperlyConfigured, ObjectDoesNotExist, PermissionDenied, SuspiciousOperation)
from django.core.paginator import InvalidPage, Paginator
from django.db import models
from django.db.models.fields import FieldDoesNotExist
from django.db.models.fields.related import ManyToManyField, OneToOneRel
from django.shortcuts import get_object_or_404, redirect
from django.template.defaultfilters import filesizeformat
Expand Down
3 changes: 2 additions & 1 deletion wagtail/search/backends/db.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from collections import OrderedDict
from warnings import warn

from django.core.exceptions import FieldDoesNotExist
from django.db import models
from django.db.models import Count
from django.db.models.expressions import Value
Expand Down Expand Up @@ -30,7 +31,7 @@ def get_fields_names(self):
for field_name in fields_names:
try:
model._meta.get_field(field_name)
except models.fields.FieldDoesNotExist:
except FieldDoesNotExist:
continue
else:
yield field_name
Expand Down
2 changes: 1 addition & 1 deletion wagtail/search/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from django.apps import apps
from django.core import checks
from django.db import models
from django.db.models.fields import FieldDoesNotExist
from django.core.exceptions import FieldDoesNotExist
from django.db.models.fields.related import ForeignObjectRel, OneToOneRel, RelatedField

from modelcluster.fields import ParentalManyToManyField
Expand Down