Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling versioned_static from static form media definitions #5644

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Avoid calling versioned_static from static form media definitions #5644

merged 2 commits into from
Oct 23, 2019

Commits on Oct 22, 2019

  1. Avoid calling versioned_static from static form media definitions 

    Fixes wagtail#5632

Defining media definitions with `class Media:` means that those lines are evaluated on application startup; this means that they cannot contain calls to the Django static file finder, because ManifestStaticFilesStorage doesn't work until collectstatic has completed. Fix this by making those definitions into `def media(self):` methods.
    @gasman
    gasman committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    08a04b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Add test to confirm that inheritance still works with dynamic form me… 

    …dia definitions
    @gasman
    gasman committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    c797881 View commit details
    Browse the repository at this point in the history