Use get_admin_display_title in PageChooserPanel #5745
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #5726 . @gasman This should fix the title of the page only in the PageChooserPanel. Do you think this is a good approach? Another approach might be to remove the
pageTitle.text()
entirely since by defaultpage_chooser.html
showsget_admin_display_title
. But I think adding a new data attribute is a better way.I think I will need to add some tests also to ensure this behaviour works. I will add the tests once you confirm that this approach looks good.
make lint
from the Wagtail root)