#5269 improve implementations of visually-hidden text in explorer and main menu toggle #5793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudcolas
force-pushed
the
5269-screen-reader-false-positives
branch
from
9d8f981
to
6bea7e4
Compare
Manage this branch in SquashTest this branch here: https://martincoote5269-screen-reader-3asud.squash.io |
thibaudcolas
changed the title
thibaudcolas
changed the title
thibaudcolas
changed the title
thibaudcolas
force-pushed
the
5269-screen-reader-false-positives
branch
from
6bea7e4
to
e207a8b
Compare
thibaudcolas
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Thank you @martincoote! I forget why we marked this as a WIP – testing it now, it’s all working (after a bit of rebasing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5269
Browser testing notes