Group users list

[karranb]

Description

This PR implements a group user listing endpoint.

Issue

#5801

[squash-labs]

Manage this branch in Squash

Test this branch here: https://karranbfeatgroup-users-list-4nml0.squash.io

[isandunk]

Thanks so much for your work on this @karranb

I've tested this in Squash. I have a couple of suggestions from a UX point of view:

• Perhaps we could rename the button so that it is more obvious what it does? So something like "View users of this group" or "View users of <group.id/>"
• In other sections of wagtail, like Images or Documents, they have actions like this in the header (eg. In Documents, it has "Add Document"). Perhaps this button would be better situated there?

Again, thanks for you work.

[karranb]

Thanks for the review. Awesome suggestions, I'll work on them 😄

[karranb]

Hey @isandunk, I had to make a small refactor on the heading component to accept other buttons besides 'add' ones. I can implement using another approach if you find one that fits better 😄

[isandunk]

Thanks @karranb! I think that's a great solution!

[lb-]

@karranb - this works great, I understand the reasoning of renaming the add_link to action_url thanks for doing a bit of house keeping there. In future it might be good to split those kinds of changes to two PRs (just easier to review).

Nonetheless, works well, code looks good and thanks for adding tests.

We will get these merged in soon, one note is that in the listing of users when filtered by groups there can be cases where there are no users in that group. I have revised the translation in this scenario to be group specific as it can be a bit confusing.

Also noticed an unrelated bug where the 'add one' (link to add users) did not actually work, have fixed this also.

Finally, a future PR (would love to see it if you want) would be to add a link to the users for a group on the group listing page also (in each row), maybe with the user count. :)

[lb-]

merged in va 7565248

thanks again @karranb