Switch Sass compilation from node-sass to dart-sass #6033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest 24 is out but upgrading to it would require us to also update our Webpack tooling to Babel 7, which is quite significant work.
Manage this branch in SquashTest this branch here: https://thibaudcolaschoredart-sass-hsfu4.squash.io |
thibaudcolas
force-pushed
the
chore/dart-sass
branch
from
23cdcb6
to
de7a042
Compare
thibaudcolas
force-pushed
the
chore/dart-sass
branch
from
de7a042
to
5548178
Compare
lb-
approved these changes
May 17, 2020
There was a problem hiding this comment.
@thibaudcolas - great stuff! This is so much easier to work with when developing, should be a great help to all those working with styles. Tested a bunch of stuff, reviewed code and cannot see any issues. Will aim to merge in shortly.
- npm ci (in vm)
- npm run lint
- npm run build (in vm & outside vm) + delete static before
- visual validation across app
- check icons render in form, time & url field
lb-
added a commit
to wagtail/vagrant-wagtail-develop
that referenced
this pull request
May 17, 2020
* native modules no longer used for sass due to adoption of `dart-sass` * wagtail/wagtail#6033 * wagtail/wagtail@7eeb44a
lb-
added a commit
to lb-/docker-wagtail-develop
that referenced
this pull request
May 17, 2020
* native modules no longer used for sass so no rebuild required (adoption of `dart-sass`) * wagtail/wagtail#6033 * wagtail/wagtail@7eeb44a
This was referenced May 17, 2020
|
Merged in via 7eeb44a PRs created as noted to remove node-sass specific build workarounds in docker/vagrant |
lb-
added a commit
to wagtail/vagrant-wagtail-develop
that referenced
this pull request
May 18, 2020
* native modules no longer used for sass due to adoption of `dart-sass`, node-sass no longer needing to be mentioned * wagtail/wagtail#6033 * wagtail/wagtail@7eeb44a
allcaps
pushed a commit
to wagtail/docker-wagtail-develop
that referenced
this pull request
May 19, 2020
* native modules no longer used for sass so no rebuild required (adoption of `dart-sass`) * wagtail/wagtail#6033 * wagtail/wagtail@7eeb44a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the changes from #5401. I had trouble with dependencies shared between node-sass and Jest 22 (jsdom 11.5) – this resolves those problems quite conveniently.
This replaces gulp-sass with a fork using the new Dart implementation of Sass, https://github.com/sass/sass. This implementation is now the canonical implementation for Sass, so is more up to date (e.g.
@use) – and also much easier to keep up to date on projects, since it’s compiled to JavaScript for the npm package, not needing native modules likenode-sassdoes.This should make it much easier for contributors to switch between working on a Vagrant box, Docker, their own computer – node-sass is our only dependency requiring native modules (there’s
fseventstoo but it’s optional). It also makes it easier to upgrade Node versions, since we don’t have to worry about node-sass having prebuilt binaries for the versions we upgrade to.This also makes the Draftail.css compilation warning go away.
As part of the upgrade I had to rewrite two bits of code that were using now-deprecated Sass features. The output CSS for those two features. The output CSS is overall nearly identical – there are a few things that are ordered differently in a way that’s not significant, and a different level of precision for math, not in a way that’s significant.
I tested this with my UI regression test suite from https://github.com/thibaudcolas/wagtail-tooling.
make lintfrom the Wagtail root)[x] For Python changes: Have you added tests to cover the new/fixed behaviour?Once this is merged we can remove: https://github.com/wagtail/docker-wagtail-develop/blob/eef59861b590ffabb54fd7c29271a4a39d9de071/Dockerfile.frontend#L9-L10
and might also be able to change: https://github.com/wagtail/vagrant-wagtail-develop/blob/master/Vagrantfile#L35.