Add chevron to dropdowns that are missing them #6242
Conversation
Manage this branch in SquashTest this branch here: https://rintifix-dropdowns-ldevx.squash.io |
|
Thank you @rinti, I’ll try to have a look as soon as I can. |
thibaudcolas
force-pushed
the
fix-dropdowns
branch
from
a5e2be7
to
1078f5c
Compare
There was a problem hiding this comment.
👍 tested in Firefox, Chrome, IE11, all looking as expected. Thank you @rinti!
| {% endfor %} | ||
| </select> | ||
| <span></span> | ||
| </div> |
There was a problem hiding this comment.
This markup looks pretty weird but I can see it’s a carbon copy of collection_chooser.html so 👍 . Thank you for digging for this.
| {% endfor %} | ||
| </select> | ||
| <span></span> | ||
| </div> |
| <div class="field choice_field"> | ||
| <form method="get" class="setting-site-switch-form" id="settings-site-switch" novalidate> | ||
| <label for="{{ site_switcher.site.id_for_label }}"> | ||
| {% trans "Site" %}: |
There was a problem hiding this comment.
Thank you 🙏 this feels like as big of a fix as the dropdown arrows missing.
| // the site setting dropdown is auto width, so the chevron will overlap with text if not padded | ||
| .choice_field .setting-site-switch-form .input select { | ||
| padding-right: 5em; | ||
| } |
There was a problem hiding this comment.
It would be nice for this to be defined in the stylesheets for that contrib app only, but I see there are no stylesheets for it right now, so that also feels overkill.
I think I’m happy with this as-is.
There was a problem hiding this comment.
Yeah I think that this perhaps should be the default for all the choosers instead, I didn't think to check but I think this problem exists for all choosers - if the choice text is long enough.
This is a fix for #6072
I reused already existing markup for dropdowns, however I needed to make a small addition to the css for the site dropdown. There might be a better way to do it so the addition isn't needed - if so I'm all ears. :)
I also added a translation tag for "Site", since I was already in the file and noticed, and it felt to minor to open a pull request for separately.
Site settings before:
Site settings after:
Adding documents before:
Adding documents after:
Adding images:
Adding images after:
