deleted the div that conatined the actionbutton class in Model Admin template #6387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was creating styling issues in the wagtailadmin.
Manage this branch in SquashTest this branch here: https://uomresearchitactionbutton-wagt-jo64f.squash.io |
|
Thank you for fixing this issue @Josh-Woodcock! 🙏🏻 Does anything prevent this from being merged? |
lb-
pushed a commit
that referenced
this pull request
May 5, 2022
- It was creating styling issues in the wagtailadmin when list export was enabled - ensure that all actions are contained within the actionbutton div
lb-
approved these changes
May 5, 2022
There was a problem hiding this comment.
@Josh-Woodcock thanks so much for this contribution a long time ago.
Apologies that it did not get a review in a short time but we really appreciate the time taken to get this together.
The header layout has changed a bit so the eventual change including this is a bit different - see 8a4a6b4
Nonetheless, it should now be resolved and thanks for making your first contribution to Wagtail!
|
Merged in via 8a4a6b4 |
stevedya
pushed a commit
to stevedya/wagtail
that referenced
this pull request
May 18, 2022
…6387) - It was creating styling issues in the wagtailadmin when list export was enabled - ensure that all actions are contained within the actionbutton div
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted the div that conatined the actionbutton class in the Model Admin template
It was creating styling issues in the Wagtail admin when I was using wagtail hooks to expose a model to the admin for moderatioon and export.
Before (w/ actionbutton)
After (without the div with actionbutton class)
I had a look at adding the same class to the
{% if view.list_export %}however it required additional styling to create space with the button above. I figured this solution would be simplest and most effective.