Issue #6388 --> Changed <input type=button> to <button type=button>

[paqman85]

Thanks for contributing to Wagtail! 🎉

Before submitting, please review the contributor guidelines https://docs.wagtail.io/en/latest/contributing/index.html and check the following:

• Do the tests still pass? (https://docs.wagtail.io/en/latest/contributing/developing.html#testing)
• Does the code comply with the style guide? (Run make lint from the Wagtail root)
• For Python changes: Have you added tests to cover the new/fixed behaviour? N/A
• For front-end changes: Did you test on all of Wagtail’s supported browsers? Please list the exact versions you tested.
• For new features: Has the documentation been updated accordingly? N/A

[squash-labs]

Manage this branch in Squash

Test this branch here: https://paqman85master-qx35g.squash.io

[Scotchester]

Thank you, @paqman85! We appreciate it.

[Scotchester]

Whoops, too hasty with my approval. <button> is not a self-closing tag, so these tags need to be converted to this format:

<button type="button" class="button">value</button>

(replacing the value with the value of the value attribute from before)

[paqman85]

No prob! I'll update it.

…

On Wed., Sep. 23, 2020, 5:33 p.m. Scott Cranfill, ***@***.***> wrote: ***@***.**** requested changes on this pull request. Whoops, too hasty with my approval. <button> is not a self-closing tag, so these tags need to be converted to this format: <button type="button" class="button">value</button> (replacing the value with the value of the value attribute from before) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6401 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADSTF3E5TYYMHWORHUYB55TSHJSSPANCNFSM4RXPR4DA> .

[paqman85]

I may have missed something again, did you want the value="drop up" to be between the button tags, not as a tag attribute?

[Scotchester]

I may have missed something again, did you want the value="drop up" to be between the button tags, not as a tag attribute?

Yes, the attribute should go away, and just drop up should appear between the tags.

[paqman85]

Ok I think I got them all now. Sorry about the extra commits!

…

On Wed, Sep 23, 2020 at 5:50 PM Scott Cranfill ***@***.***> wrote: I may have missed something again, did you want the value="drop up" to be between the button tags, not as a tag attribute? Yes, the attribute should go away, and just drop up should appear between the tags. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6401 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADSTF3HU5BITTEZJL6V7II3SHJURTANCNFSM4RXPR4DA> .

[Scotchester]

Beautiful, thanks again, @paqman85!