Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SVG icons in ModelAdmin menu items #6402

Merged
merged 3 commits into from
Sep 25, 2020
Merged

Support SVG icons in ModelAdmin menu items #6402

merged 3 commits into from
Sep 25, 2020

Commits on Sep 25, 2020

  1. Support SVG icons in ModelAdmin menu items 

    Support is already present in the MenuItem and SubmenuMenuItem classes 
that ModelAdminMenuItem and GroupMenuItem subclass (and their respective 
templates), but those two subclasses needed to be updated to pass the 
new `icon_name` kwarg.

This commit retains support for the popular wagtail-fontawesome package 
by checking for `menu_icon` properties beginning with `fa-`, and 
following the same old `classname` logic as before. If that's not found, 
it sets the `icon_name` kwarg which triggers the SVG icon rendering in 
the template.
    @Scotchester @thibaudcolas
    Scotchester authored and thibaudcolas committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    3fa6343 View commit details
    Browse the repository at this point in the history

  2. Change name of default modeladmin group icon

    @thibaudcolas
    thibaudcolas committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    6c52cce View commit details
    Browse the repository at this point in the history

  3. Release notes for #6402

    @thibaudcolas
    thibaudcolas committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    8f6230d View commit details
    Browse the repository at this point in the history