Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change embed finder credit order #6636

Merged
merged 1 commit into from Dec 16, 2020
Merged

Change embed finder credit order #6636

merged 1 commit into from Dec 16, 2020

Conversation

originell
Copy link
Contributor

@originell originell commented Dec 14, 2020

It's a really small thing, but I honestly feel like Cynthia did most of the work of taking my workaround to production quality code and pushing it over the finish line. So she should be first here.

Thanks for contributing to Wagtail! 馃帀

Before submitting, please review the contributor guidelines https://docs.wagtail.io/en/latest/contributing/index.html and check the following:

  • Do the tests still pass? (https://docs.wagtail.io/en/latest/contributing/developing.html#testing)
    Yes

  • Does the code comply with the style guide? (Run make lint from the Wagtail root)
    Yes

  • For Python changes: Have you added tests to cover the new/fixed behaviour?
    n/a

  • For front-end changes: Did you test on all of Wagtail鈥檚 supported browsers? Please list the exact versions you tested.
    n/a

  • For new features: Has the documentation been updated accordingly?
    n/a

It's a really small thing, but I honestly feel like Cynthia did most of the work of taking my workaround to production quality code and pushing it over the finish line. So she should be first here.
@squash-labs
Copy link

squash-labs bot commented Dec 14, 2020

Manage this branch in Squash

Test this branch here: https://originellpatch-2-dm1hp.squash.io

@gasman gasman merged commit e48c170 into wagtail:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants