Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial linting pass over all legacy JS #6653

Merged
merged 4 commits into from Dec 22, 2020
Merged

Initial linting pass over all legacy JS #6653

merged 4 commits into from Dec 22, 2020

Conversation

kaedroho
Copy link
Contributor

@kaedroho kaedroho commented Dec 20, 2020 •
edited

Just fixing the most common errors like:

  • Indent with 2 spaces
  • Replace var with let/const
  • Replace function() expressions with arrow functions
  • A few other trivial tweaks like spacing

I've made eslint ignore all non-trivial issues for now

@kaedroho kaedroho requested a review from gasman December 20, 2020 14:16
@squash-labs
Copy link

squash-labs bot commented Dec 20, 2020

Manage this branch in Squash

Test this branch here: https://kaedroholint-legacy-js-39b14.squash.io

@kaedroho kaedroho force-pushed the lint-legacy-js branch 2 times, most recently from c41868a to f359dde Compare December 20, 2020 14:27
gasman
gasman requested changes Dec 20, 2020
View reviewed changes
client/src/entrypoints/core.js Outdated Show resolved Hide resolved
@kaedroho kaedroho force-pushed the lint-legacy-js branch 2 times, most recently from ea7c712 to 15228b3 Compare December 21, 2020 14:58
gasman
gasman approved these changes Dec 22, 2020
View reviewed changes
Copy link
Collaborator

@gasman gasman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! In the process of testing I noticed that the userbar has stopped working since the js was moved into client (27133f9), so will merge now and open a new issue for that.

@gasman gasman merged commit fe79fbb into wagtail:master Dec 22, 2020
@kaedroho kaedroho deleted the lint-legacy-js branch December 22, 2020 23:41
@kaedroho
Copy link
Contributor Author

Thanks! Will look into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasman gasman gasman approved these changes

Assignees
No one assigned
Labels
type:Cleanup/Optimisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaedroho @gasman @zerolab