Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telepath integration for commenting #6932

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

kaedroho
Copy link
Contributor

This is the simplest approach by adding data-contentpath attributes to streamfield blocks which are currently picked up by the commenting system.

@squash-labs
Copy link

squash-labs bot commented Mar 19, 2021

Manage this branch in Squash

Test this branch here: https://featurecommenting-telepath-ub9yj.squash.io

@kaedroho kaedroho requested review from jacobtoppm and removed request for jacobtoppm March 19, 2021 10:39
@kaedroho kaedroho force-pushed the feature/commenting-telepath branch from 4e29941 to 8d4bfee Compare March 30, 2021 14:12
@kaedroho
Copy link
Contributor Author

Rebased!

Copy link
Member

@jacobtoppm jacobtoppm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@jacobtoppm jacobtoppm merged commit ee88492 into feature/commenting Mar 31, 2021
@kaedroho kaedroho deleted the feature/commenting-telepath branch April 6, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants