Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New styling for commenting #6952

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

kaedroho
Copy link
Contributor

@squash-labs
Copy link

squash-labs bot commented Mar 30, 2021

Manage this branch in Squash

Test this branch here: https://featurecommenting-new-styling-o8ko9.squash.io

@kaedroho kaedroho marked this pull request as ready for review March 31, 2021 08:32
Copy link
Member

@jacobtoppm jacobtoppm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking great, but 2 issues right now:

  • Adding a new reply causes no avatar to show on the added reply (all other avatars on existing replies display fine)
  • On Chrome, at various levels of zoom, the circles surrounding the avatar seem to have gaps in some places between the avatar and the border, which look a little odd. The border itself also looks a little pixellated - any way we could smooth this a little more? (This is a minor visual bug, but thought I'd mention)

@jacobtoppm jacobtoppm merged commit d4d9b00 into feature/commenting Mar 31, 2021
@kaedroho kaedroho deleted the feature/commenting-new-styling branch April 6, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants