Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts inline panel anchor to button to make keyboard focusable. #7346

Merged
merged 3 commits into from
Jul 24, 2021
Merged

Converts inline panel anchor to button to make keyboard focusable. #7346

merged 3 commits into from
Jul 24, 2021

Conversation

jessemenn
Copy link
Contributor

This allows the InlinePanel button to be keyboard navigable and targetable with VoiceOver.

Before submitting, please review the contributor guidelines https://docs.wagtail.io/en/latest/contributing/index.html and check the following:

  • For front-end changes: Did you test on all of Wagtail’s supported environments?
    • Please list the exact browser and operating system versions you tested.
      • macOS Chrome, Firefox ESR, Safari
    • Please list which assistive technologies you tested.
      • VoiceOver on macOS with Safari

@squash-labs
Copy link

squash-labs bot commented Jul 16, 2021

Manage this branch in Squash

Test this branch here: https://jessemenninline-panel-button-d50u0.squash.io

@Stormheg
Copy link
Member

Stormheg commented Jul 24, 2021

Thanks @jessemenn 🚀 ⌨️

This looks good and I can confirm this solves the issue.

Here are some things I noticed during testing with bakery demo, out of scope for this PR

  • 'ADD' is spelled instead of pronounced as a word. I think this is a common issue in Wagtail in general.
  • There is no feedback after clicking the button. I would expect focus to change to the new item and VoiceOver to announce a new item has been added.

@Stormheg Stormheg merged commit 1a75634 into wagtail:main Jul 24, 2021
WCAG2.1 & ATAG 2.0 for CMS automation moved this from In progress to Done Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants