Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "undefined label" warnings caused by missing leading underscore #7347

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

cnk
Copy link
Member

@cnk cnk commented Jul 17, 2021

I saw the following warnings while building docs locally with make html:

writing output... [100%] topics/writing_templates
/Code/wagtail-dev/wagtail/docs/releases/1.11.rst:102: WARNING: undefined label: page_urls (if the link has no caption the label must precede a section header)
/Code/wagtail-dev/wagtail/docs/releases/1.6.1.rst:36: WARNING: undefined label: custom_page_managers (if the link has no caption the label must precede a section\
 header)
/Code/wagtail-dev/wagtail/docs/topics/permissions.rst:28: WARNING: undefined label: page_type_business_rules (if the link has no caption the label must precede a\
 section header)
generating indices... py-modindex done
writing additional pages... search done

Adding back the initial underscore in labels inside the eval_rst blocks make these error messages go away AND allow me to link to the page_type_business_rules section from the docs I was updating when I saw these warnings.

Before submitting, please review the contributor guidelines https://docs.wagtail.io/en/latest/contributing/index.html and check the following:

@squash-labs
Copy link

squash-labs bot commented Jul 17, 2021

Manage this branch in Squash

Test this branch here: https://cnkfix-links-in-docs-r20my.squash.io

Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @cnk

@gasman gasman merged commit 07e03bc into wagtail:main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants