Eliminate use of re_path from integration docs #7351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `re_path` for the page serve view is unnecessary (the project template doesn't do it) and will be increasingly unfamiliar to new Django devs as `path` becomes more widespread.
Manage this branch in SquashTest this branch here: https://docsintegration-remove-repath-lz6np.squash.io |
zerolab
approved these changes
Jul 20, 2021
| Note that there's one small difference when not using the Wagtail project template: Wagtail creates an initial homepage of the basic type `Page`, which does not include any content fields beyond the title. You'll probably want to replace this with your own `HomePage` class - when you do so, ensure that you set up a site record (under Settings / Sites in the Wagtail admin) to point to the new homepage. |
There was a problem hiding this comment.
note: this is some kind of whitespace change but for the life of me can't spot what it is
There was a problem hiding this comment.
Apparently there was no newline at the end of the file in the old version. (I used the Github online editor to make this change, so that must add it automatically...)
There was a problem hiding this comment.
I could swear the diff view in GitHub used to show the lack of EOF new lines. Oh well 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
re_pathfor the page serve view is unnecessary (the project template doesn't do it) and will be increasingly unfamiliar to new Django devs aspathbecomes more widespread.